hey all

My appointment is coming up soon so it's time to have an all around review of my document checklist. I am applying from within the UK transferring from tier-2 work visa. I know it's very tedious to look through all of them so your time and effort is much appreciated!! xoxo
Doc # of copies
application form x1
receipt of IHS x1
receipt of application x1
Photos&IDs
Passport of the applicant x1 new x1 expired
Passport photo of the sponsor x1
Passport photo of the applicant x2
BRP of the applicant x1
British Passport of the sponsor x1 (he's also American citizen, does he need to provide both?)
Cover letter from the sponsor x1
Proof of living together for 2 years
A letter from the former flatmate confirming sponsor&applicant lived with him for 1 year from Apr 2016 to Apr 2017 x1
Tenancy agreement of our current flat as evidence of monthly housing cost in the UK x1
Council tax letter as evidence of council tax costs for the current accommodation in the UK x1
Items of correspondence from May 12th 2016 to May 23rd 2018(each dates 3 months apart) x14
- joint documents x4
- individual documents x10
Financial proof of the applicant, source of income: employment
A letter from current employer(HR) confirming the applicant's: the employment, gross annual salary, length of the employment til date(since Apr 2016), type of employment x1
P60 for 2016-2017 x1
P60 for 2017-2018 x1
6 Monthly pay slips til July 2018(waiting for the July pay slip to be issued) x6
Letter from employer(Finance Director) confirming the authenticity of the P60s and pay slips(he also initialled each P60 and pay slip) x1
6 Monthly bank statement til July 2018(still waiting for the July statement to be mailed to me) x6
1 concern: my appointment was made under my old passport number before I got it renewed, I hope this won't cause any issue?