We were there on our honeymoon in April '00-and I think it is the best city I have ever visited. I love love loved it, it is stunningly gorgeous and we had a wonderful time.
The weather in April was perfect-cold enough for coats but not deathly cold. I like the cold, though, so am eager to go in winter.
I don't think two years would be long enough to really absorb everything (
) but two weeks would be enough, I think, to see a lot. You can do Holyrood House, the Royal Mile, and Edinburgh Castle in a day if you're fast and early, but two is better and three leaves time for wandering. The rest of the time you can see all the less well-known but still neat stuff.
I'm so jealous. I waannnnaaa goooo!!!!!